Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(object-store): remove async_trait macro on StreamingUploader and refine object store macro #16800

Merged
merged 4 commits into from
May 20, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented May 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Removed #[async_trait] on StreamingUploader trait, and avoid using box dyn on streaming uploader, so that each call on write_bytes won't create a boxed future. StreamingUploader now becomes an associated type of ObjectStore. An StreamingUploaderImpl enum will be used to manually dispatch to different variant.

Refined the macro used in object store trait. Previously, we have many macros that lists all variants of object store. With this PR, we only need to declare the list of all variants in a single macro for_all_object_store, and all other macros will call for_all_object_store to get the list of object store variants.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 changed the title refactor(object-store): remove async_trait macro on StreamingUploader and refactor object store macro refactor(object-store): remove async_trait macro on StreamingUploader and refine object store macro May 17, 2024
@wenym1 wenym1 requested review from hzxa21, Li0k and wcy-fdu May 20, 2024 05:34
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 8b5a7bc May 20, 2024
28 of 29 checks passed
@wenym1 wenym1 deleted the yiming/object-store-macro branch May 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants