refactor(object-store): remove async_trait macro on StreamingUploader and refine object store macro #16800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Removed
#[async_trait]
onStreamingUploader
trait, and avoid using box dyn on streaming uploader, so that each call onwrite_bytes
won't create a boxed future.StreamingUploader
now becomes an associated type ofObjectStore
. AnStreamingUploaderImpl
enum will be used to manually dispatch to different variant.Refined the macro used in object store trait. Previously, we have many macros that lists all variants of object store. With this PR, we only need to declare the list of all variants in a single macro
for_all_object_store
, and all other macros will callfor_all_object_store
to get the list of object store variants.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.